Multiple attachments on an initiative

[virgile-dev]

Describe the bug
These were found while doing QA on #5736

In the edit form one is under the impression they can add other attachements (the plural form attachements is used both in the wizard and the edit form). But when doing so the attachement that was already on the initiative gets replaced by the one newly uploaded. The new attachement should be added and not replace the one that was already there.

Users should be to add several attachement while creating the initiative via the wizard.

I tested adding more attachements via the admin and they display correctly.

Also I notice that when hitting the cross to delete the attachement and clicking on the update button the attachment still displays on the initiative.

[virgile-dev]

About the upload, it's following the behaviour of the other modules, let me know if you want me to change it

@carolromero as edgar mentionned above in this comment we need to decide how we want to handle multiple attachements on initiative.

[carolromero]

@virgile-dev yes, I would change the system so that adding new attachments doesn't delete the previous ones. Are you guys thinking of sending a PR of this?

[virgile-dev]

@carolromero no PR in the pipe, we are running on low on dev ressources this end of year 😔

[oriolgual]

Fix can be tested here https://decidim-staging-pr-309.herokuapp.com

[mrcasals]

In #7452 (comment) @ahukkanen raises this concern:

This same bug exists in all places where attachments can be added similarly (e.g. proposals), so I'd suggest fixing it once and for all.

@decidim/product could you confirm how to handle this?

[carolromero]

@oriolgual I'm getting a server error when creating an initiative type.

[andreslucena]

Hi all! Seems like this issue and PR has stagnated :/

This same bug exists in all places where attachments can be added similarly (e.g. proposals), so I'd suggest fixing it once and for all.

@decidim/product could you confirm how to handle this?

Let's fix this bug

[andreslucena]

Fix can be tested here decidim-staging-pr-309.herokuapp.com

Seems like (obviously) the review PR isn't working anymore

@oriolgual I'm getting a server error when creating an initiative type.

I tried this locally but still have the same bug regarding the attachments deletion:

bug-initiatives-attachment.mp4