Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport 'Ignore the problematics HTML validation checks with hidden inputs' to v0.27 #10025

Conversation

ahukkanen
Copy link
Contributor

馃帺 What? Why?

Backport #10020 to v0.27

鈾ワ笍 Thank you!

* Ignore the problematic HTML validation check with Rails

Rails adds  automatically to hidden inputs
which is not valid HTML.

But we need to preserve this functionality for the time being
because of a Firefox bug that is fixed using this workaround.

* Prevent aria-describedby attribute being added to hidden inputs

* Revert "Prevent aria-describedby attribute being added to hidden inputs"

This reverts commit 5a90162.

* Ignore the aria-* attributes rule with hidden inputs

* Add reference to the foundation issue

Co-authored-by: Andr茅s Pereira de Lucena <andreslucena@users.noreply.github.com>

* Remove unnecessary whitespace

Co-authored-by: Andr茅s Pereira de Lucena <andreslucena@users.noreply.github.com>

Co-authored-by: Andr茅s Pereira de Lucena <andreslucena@users.noreply.github.com>
@ahukkanen ahukkanen added backport Pull Requests that are a backport for a fixed bug module: dev type: internal PRs that aren't necessary to add to the CHANGELOG for implementers labels Nov 3, 2022
Copy link
Member

@andreslucena andreslucena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

馃憤馃徑

@andreslucena andreslucena merged commit 8e77bcb into release/0.27-stable Nov 3, 2022
@andreslucena andreslucena deleted the backport/0.27/ignore-the-problematics-html-v-10020 branch November 3, 2022 09:18
@alecslupu alecslupu added this to the 0.27.1 milestone Jul 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Pull Requests that are a backport for a fixed bug module: dev type: internal PRs that aren't necessary to add to the CHANGELOG for implementers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants