Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Display Published meetings in Assembly cell #10208

Merged
merged 1 commit into from Feb 6, 2023
Merged

Display Published meetings in Assembly cell #10208

merged 1 commit into from Feb 6, 2023

Conversation

alecslupu
Copy link
Contributor

@alecslupu alecslupu commented Jan 7, 2023 •
edited

馃帺 What? Why?

The meeting is being displayed in assembly cell when an admin creates a future meetinging and leaves it unpublished. This PR aims to fix this.

馃搶 Related Issues

Link your PR to an issue

Testing

  1. Login as admin, and visit the admin area
  2. Select an assembly and create a future meeting without publish it
  3. visit the public interface and see the meeting is displayed in the assembly card
  4. Apply the patch and restart the server
  5. Observe the draft meeting is not being displayed there

鈾ワ笍 Thank you!

@alecslupu alecslupu requested a review from a team January 9, 2023 10:12
@alecslupu alecslupu marked this pull request as ready for review January 9, 2023 10:12
@alecslupu alecslupu added module: meetings module: assemblies type: fix PRs that implement a fix for a bug labels Jan 9, 2023
@alecslupu alecslupu added this to Pending review from Product in Maintainers via automation Jan 11, 2023
@alecslupu alecslupu removed this from Pending review from Product in Maintainers Jan 25, 2023
fblupi
fblupi approved these changes Feb 6, 2023
View reviewed changes
Copy link
Member

@fblupi fblupi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@fblupi fblupi merged commit d090b2d into decidim:develop Feb 6, 2023
@alecslupu alecslupu deleted the published-meetings branch February 6, 2023 15:04
This was referenced Feb 6, 2023
Merged
Merged
@alecslupu alecslupu mentioned this pull request Jul 19, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fblupi fblupi fblupi approved these changes

Assignees
No one assigned
Labels
module: assemblies module: meetings type: fix PRs that implement a fix for a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unpublished meeting appears on assembly cell
2 participants
@alecslupu @fblupi