Backport 'Fix filter URL not updated with the text search input' to v0.27 #10264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alecslupu
added
backport
* Fix the URL not updated when the filter form text inputs are changed * Update the form filter jest tests accordingly to the changes * Add system specs to test the URL is updated after text search * Fix additional history state pushes on form submit during pops * Fix the value in the UID * Fix the Jest tests after adding the event argument to form submit * Add Jest test checking that the state is not re-pushed on popstate
alecslupu
force-pushed
the
backport/0.27/fix-filter-url-not-updated-wit-9618
branch
from
8fd5bbb
to
40d0170
Compare
|
Codecov Failing. Known issue |
alecslupu
moved this from Pending review from Product
to To Review by Core
in Maintainers
ahukkanen
approved these changes
Jan 30, 2023
ahukkanen
deleted the
backport/0.27/fix-filter-url-not-updated-wit-9618
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
馃帺 What? Why?
Backport #9618 to v0.27