Rename Decidim.password_blacklist to Decidim.denied_passwords #10288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alecslupu
force-pushed
the
fix/6678
branch
2 times, most recently
from
a935b77
to
ec17e78
Compare
ahukkanen
added
module: admin
type: fix
ahukkanen
requested changes
Jan 31, 2023
|
On it ! |
|
I have looked, and changing the blacklist may be too complex for the scope. We will need to rename PasswordValidator#blacklisted? Going a step further, we may need to rename the Shall we go on this rabbit hole ? |
|
Yeah, I think we need to do that and relabel this as We did something similar before as well with the "download your data" terminology which required a lot of such changes (see #9196). |
ahukkanen
added
type: change
alecslupu
changed the title
|
Thanks for addressing this! 馃挄 |
|
@ahukkanen this can now be reviewed. |
alecslupu
moved this from Pending review from Product
to To Review by Core
in Maintainers
ahukkanen
requested changes
Feb 23, 2023
ahukkanen
approved these changes
Mar 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
馃帺 What? Why?
Rename several terms like "blacklist", "whitelist".
馃搶 Related Issues
Link your PR to an issue
Testing
Describe the best way to test or validate your PR.
馃摲 Screenshots
Please add screenshots of the changes you're proposing
