Switch to the official Codecov action for CI #10344
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahukkanen
added
the
type: internal
alecslupu
approved these changes
Feb 14, 2023
ahukkanen
added a commit
that referenced
this pull request
Mar 1, 2023
* Switch to the official Codecov action v3 * Revert "Split parallel test coverage reports into their own folders (#9686)" This reverts commit dba6811. * Use working-directory instead of the directory argument * Add unique name to the decidim-core coverage reports * Move the working-directory under the with arguments * Remove working-directory as the report is always at the root * Define the flag argument similarly to the old uploader * Remove the legacy coverage uploader * Hard code the CodeCov token to the workflow files
|
@decidim/maintainers I'd like to backport also this to 0.26 and 0.27 because we still have the upload failures happening during backports. Please see the backport PRs. |
alecslupu
pushed a commit
that referenced
this pull request
Mar 1, 2023
) * Switch to the official Codecov action for CI (#10344) * Switch to the official Codecov action v3 * Revert "Split parallel test coverage reports into their own folders (#9686)" This reverts commit dba6811. * Use working-directory instead of the directory argument * Add unique name to the decidim-core coverage reports * Move the working-directory under the with arguments * Remove working-directory as the report is always at the root * Define the flag argument similarly to the old uploader * Remove the legacy coverage uploader * Hard code the CodeCov token to the workflow files * Switch to the codecov action at the rest of the workflows
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
In order to try to fix the issues with uploading reports to Codecov, let's switch to the official Codecov action v3.
I am also reverting #9686 in this PR because that turned out to be unnecessary as far as we know right now.
While doing this change I also noticed that in some of the old workflows, we did not uniquely name all the reports e.g. in case some module's tests are split into multiple workflows. This was the case e.g. with initiatives and generators. That might have also had something to do with the failures, not sure... Anyways, I am also fixing that issue with this PR.
📌 Related Issues
Testing
See that the reports are uploaded to Codecov correctly.