-
-
Notifications
You must be signed in to change notification settings - Fork 393
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/redesign components breadcrumb #10441
Feature/redesign components breadcrumb #10441
Conversation
7f655a6
to
6538c2a
Compare
1fd8bc1
to
8ce0c44
Compare
…concern and define breadcrumb cell from space manifest
This reverts commit 51988c1.
8ce0c44
to
a45eee2
Compare
…o slug is present
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Checking the local version of the breadcrumb implementation i see some issues with the menu indentation. Based on the staging link, the behavior is not present.
I have a very small change request.
I have seen there are some pipelines that were failing. I have retriggered them, yet, in some cases, the issue persists. Could you have a look ?
...dim-core/app/views/layouts/decidim/header/_redesigned_menu_breadcrumb_mobile_tablet.html.erb
Outdated
Show resolved
Hide resolved
...dim-core/app/views/layouts/decidim/header/_redesigned_menu_breadcrumb_mobile_tablet.html.erb
Outdated
Show resolved
Hide resolved
…_breadcrumb_mobile_tablet.html.erb Co-authored-by: Alexandru Emil Lupu <contact@alecslupu.ro>
…_breadcrumb_mobile_tablet.html.erb Co-authored-by: Alexandru Emil Lupu <contact@alecslupu.ro>
Solved the indentation problem |
Tests and indentation fixed. Merging... |
…rafts * feature/redesign: Feature/redesign components breadcrumb (#10441) Redesign: debates (#10653) Redesign: Remove reference to commentable in activity cell (#10816) Redesign: spinner (#10848) Redesign: omnipresent banner (#10847) Add redesign enable ENV variable to control the pipeline (#10610) Redesign: progress bar (#10638) Redesign: meeting cards (#10722) Redesign: pending login (#10699) simplify 2col layout (#10819) Redesign: processes groups content blocks (#10491) Redesign: assemblies content blocks (#10573)
* feature/redesign: (21 commits) Feature/redesign components breadcrumb (#10441) Redesign: debates (#10653) Redesign: Remove reference to commentable in activity cell (#10816) Redesign: spinner (#10848) Redesign: omnipresent banner (#10847) Add redesign enable ENV variable to control the pipeline (#10610) Redesign: progress bar (#10638) Redesign: meeting cards (#10722) Redesign: pending login (#10699) simplify 2col layout (#10819) Redesign: processes groups content blocks (#10491) Redesign: assemblies content blocks (#10573) Redesign: process & process group cards (#10716) Redesign: conference cards (#10502) Redesign: pending blogs (#10686) Redesign: blog cards (#10685) Redesign: filters (#10390) replace uses of specific margin-bottom for layout margins (#10675) Redesign: menu mobile (#10351) Fix comments scss to avoid compilation errors (#10657) ...
…blies-details-page * feature/redesign: Redesign: amendments (#10765) Redesign: proposals (#10555) Remove unused preset-env dependencies (#10916) Feature/redesign components breadcrumb (#10441) Redesign: debates (#10653) Redesign: Remove reference to commentable in activity cell (#10816) Redesign: spinner (#10848) Redesign: omnipresent banner (#10847) Add redesign enable ENV variable to control the pipeline (#10610)
* feature/redesign: Redesign: amendments (#10765) Redesign: proposals (#10555) Remove unused preset-env dependencies (#10916) Feature/redesign components breadcrumb (#10441) Redesign: debates (#10653) Redesign: Remove reference to commentable in activity cell (#10816) Redesign: spinner (#10848) Redesign: omnipresent banner (#10847) Add redesign enable ENV variable to control the pipeline (#10610)
* feature/redesign: Redesign: amendments (#10765) Redesign: proposals (#10555) Remove unused preset-env dependencies (#10916) Feature/redesign components breadcrumb (#10441) Redesign: debates (#10653) Redesign: Remove reference to commentable in activity cell (#10816) Redesign: spinner (#10848) Redesign: omnipresent banner (#10847) Add redesign enable ENV variable to control the pipeline (#10610) Redesign: progress bar (#10638) Redesign: meeting cards (#10722) Redesign: pending login (#10699)
* feature/redesign: Redesign: amendments (#10765) Redesign: proposals (#10555) Remove unused preset-env dependencies (#10916) Feature/redesign components breadcrumb (#10441) Redesign: debates (#10653) Redesign: Remove reference to commentable in activity cell (#10816) Redesign: spinner (#10848) Redesign: omnipresent banner (#10847) Add redesign enable ENV variable to control the pipeline (#10610) Redesign: progress bar (#10638) Redesign: meeting cards (#10722) Redesign: pending login (#10699)
🎩 What? Why?
This PR:
📌 Related Issues
Link your PR to an issue
Testing
Examples of breadcrumbs:
📷 Screenshots
Please add screenshots of the changes you're proposing