Backport 'Fix dynamic upload file field required indicator + make option naming consistent' to v0.27 #10541
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alecslupu
added
backport
… consistent (#10497) * Fix file field required indicator + consistency on option naming - Fix missing required file indicator from the dynamic upload file field label - Refactor the `optional` option for the file field and upload modal to `required` (inverse option) to maintain concistency over the option naming for all form fields * Fix a11y issue with the label `for` attribute in the upload label
alecslupu
force-pushed
the
backport/0.27/fix-dynamic-upload-file-field--10497
branch
from
6c35c3e
to
b46eb25
Compare
fblupi
approved these changes
Mar 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
Backport #10497 to v0.27