Fix empty proposals component configuration limits

[alecslupu]

🎩 What? Why?

While investigating the fix for #10525, i have tried to remove all the integer field values so i could test some edge cases. This PR fixes the errors found during that test.

📌 Related Issues

Link your PR to an issue

• Fixes Deleting Boolean values from Proposal config will trigger errors #10548

Testing

1. Go to proposals component config
2. Remove all the values from integer fields, press update
3. Visit component in the public view
4. See it fails
5. Apply patch, restart server to reload proposal manifest
6. Repeat 1, 2, fill in required fields, press update
7. Visit component in the public view
8. See there are no errors

♥️ Thank you!

[alecslupu]

to add : proposal_edit_before_minutes
comments_max_length

[andreslucena]

For these two, it works as expected.

But after searching for these I found other attributes that give the same error: the form let you save them empty and then going to the frontend page you'll see an exception.

These are the ones that I could reproduce it:

decidim-accountability/lib/decidim/accountability/component.rb:    settings.attribute :comments_max_length, type: :integer, required: false
decidim-blogs/lib/decidim/blogs/component.rb:    settings.attribute :comments_max_length, type: :integer, required: false
decidim-budgets/lib/decidim/budgets/component.rb:    settings.attribute :comments_max_length, type: :integer, required: false
decidim-debates/lib/decidim/debates/component.rb:    settings.attribute :comments_max_length, type: :integer, required: false
decidim-dev/lib/decidim/dev/test/rspec_support/component.rb:    settings.attribute :comments_max_length, type: :integer, required: false
decidim-meetings/lib/decidim/meetings/component.rb:    settings.attribute :comments_max_length, type: :integer, required: false
decidim-proposals/lib/decidim/proposals/component.rb:    settings.attribute :comments_max_length, type: :integer, required: false
decidim-sortitions/lib/decidim/sortitions/component.rb:    settings.attribute :comments_max_length, type: :integer, required: false
decidim-proposals/lib/decidim/proposals/component.rb:    settings.attribute :proposal_edit_before_minutes, type: :integer, default: 5
decidim-proposals/lib/decidim/proposals/component.rb:    settings.attribute :threshold_per_proposal, type: :integer, default: 0

Can you check them out please?

(After saving this, I saw your comment that you've found a couple of these one too, so ping me when that's implemented 😄)

[alecslupu]

For these two, it works as expected.

But after searching for these I found other attributes that give the same error: the form let you save them empty and then going to the frontend page you'll see an exception.

These are the ones that I could reproduce it:

decidim-accountability/lib/decidim/accountability/component.rb:    settings.attribute :comments_max_length, type: :integer, required: false
decidim-blogs/lib/decidim/blogs/component.rb:    settings.attribute :comments_max_length, type: :integer, required: false
decidim-budgets/lib/decidim/budgets/component.rb:    settings.attribute :comments_max_length, type: :integer, required: false
decidim-debates/lib/decidim/debates/component.rb:    settings.attribute :comments_max_length, type: :integer, required: false
decidim-dev/lib/decidim/dev/test/rspec_support/component.rb:    settings.attribute :comments_max_length, type: :integer, required: false
decidim-meetings/lib/decidim/meetings/component.rb:    settings.attribute :comments_max_length, type: :integer, required: false
decidim-proposals/lib/decidim/proposals/component.rb:    settings.attribute :comments_max_length, type: :integer, required: false
decidim-sortitions/lib/decidim/sortitions/component.rb:    settings.attribute :comments_max_length, type: :integer, required: false
decidim-proposals/lib/decidim/proposals/component.rb:    settings.attribute :proposal_edit_before_minutes, type: :integer, default: 5
decidim-proposals/lib/decidim/proposals/component.rb:    settings.attribute :threshold_per_proposal, type: :integer, default: 0

Can you check them out please?

(After saving this, I saw your comment that you've found a couple of these one too, so ping me when that's implemented smile)

To be honest, i would like to address the issues of other components in a different PR.

[andreslucena]

To be honest, i would like to address the issues of other components in a different PR.

OK, no problem

[alecslupu]

To be honest, i would like to address the issues of other components in a different PR.

OK, no problem

Fixed here #10561

[andreslucena]

Just a minor change

[andreslucena]

LGTM 👍🏽