Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the link handling #10611

Merged
merged 16 commits into from Apr 5, 2023
Merged

Improve the link handling #10611

merged 16 commits into from Apr 5, 2023

Conversation

alecslupu
Copy link
Contributor

🎩 What? Why?

Improve link handling of the redirect engine.

📌 Related Issues

Testing

Describe the best way to test or validate your PR.

♥️ Thank you!

@alecslupu alecslupu added this to Pending review from Product in Maintainers via automation Mar 22, 2023
@alecslupu alecslupu marked this pull request as ready for review March 22, 2023 09:30
@alecslupu alecslupu requested a review from a team March 25, 2023 00:03
Copy link
Contributor

@ahukkanen ahukkanen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is one helper defined which I don't see existing or used anywhere.

decidim-core/app/controllers/decidim/links_controller.rb Outdated Show resolved Hide resolved
@alecslupu alecslupu merged commit c39a748 into develop Apr 5, 2023
45 checks passed
Maintainers automation moved this from Pending review from Product to Done Apr 5, 2023
@alecslupu alecslupu deleted the fix/improve-link-handling branch April 5, 2023 08:15
@andreslucena andreslucena added the type: fix PRs that implement a fix for a bug label Nov 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module: core team: security type: fix PRs that implement a fix for a bug
Projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants