Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for exporting hidden moderated proposals #10630

Merged
merged 2 commits into from Mar 29, 2023
Merged

Fix for exporting hidden moderated proposals #10630

merged 2 commits into from Mar 29, 2023

Conversation

alecslupu
Copy link
Contributor

@alecslupu alecslupu commented Mar 24, 2023

🎩 What? Why?

Currently, exports in Decidim will also expose the moderated content.

📌 Related Issues

Testing

  1. Go to public interface of a proposal
  2. Report the proposal
  3. Go to admin space in the moderated section, and hide it
  4. Export the proposals in the space admin, and see the moderated content is there
  5. Apply patch
  6. Repeat step 4
  7. The exported archive should NOT contain moderated and hidden resources

♥️ Thank you!

@alecslupu alecslupu added module: proposals type: fix PRs that implement a fix for a bug labels Mar 27, 2023
@alecslupu alecslupu marked this pull request as ready for review March 27, 2023 20:19
@alecslupu alecslupu requested a review from a team March 27, 2023 20:20
@alecslupu alecslupu added this to Pending review from Product in Maintainers via automation Mar 27, 2023
@andreslucena andreslucena changed the title Fix: Hidden moderated proposals are exported Fix for exporting hidden moderated proposals Mar 28, 2023
Copy link
Member

@andreslucena andreslucena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can confirm that this is working locally. Just a string to fix and we're good to go

Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com>
@alecslupu alecslupu moved this from Pending review from Product to To Review by Core in Maintainers Mar 29, 2023
@alecslupu alecslupu dismissed andreslucena’s stale review March 29, 2023 12:22

The review recommendation has been implemented, Fran approved for maintainers

@alecslupu alecslupu merged commit babb5fd into develop Mar 29, 2023
13 checks passed
Maintainers automation moved this from To Review by Core to Done Mar 29, 2023
@alecslupu alecslupu deleted the fix/6398 branch March 29, 2023 12:23
entantoencuanto added a commit that referenced this pull request Jun 8, 2023
* feature/redesign: (70 commits)
  Fix failing specs
  Redesign sortitions (#10831)
  Redesign: data toggle (#10886)
  Redesign: collaborative drafts (#10729)
  Redesign: pending pages (#10944)
  Redesign: my account (#10904)
  use foundation classes instead of default html validation (#10921)
  Fix failings redesign specs
  Add gitpod support (#10641)
  Fix pipeline after #10409 (#10670)
  Upgrade webpack and other javascript libraries (#10643)
  New Crowdin updates (#10409)
  Refactor attachment title (#10103)
  Fix for exporting hidden moderated proposals (#10630)
  Fix Exception as admin on a Proposal with meeting author (#10628)
  Fix: Deleted and hidden comments are exported (#10629)
  Rename "terms and conditions" to "terms of service" (#10614)
  Upgrade Graphql to 2.0.19 and Graphql-Api to 3.0.1 (#10606)
  Standardize the format of the words "they will" (#10617)
  Fix the spec after word standardization (#10624)
  ...
entantoencuanto added a commit that referenced this pull request Jun 12, 2023
…blies-details-page

* feature/redesign: (71 commits)
  Unskip tests (#10951)
  Fix failing specs
  Redesign sortitions (#10831)
  Redesign: data toggle (#10886)
  Redesign: collaborative drafts (#10729)
  Redesign: pending pages (#10944)
  Redesign: my account (#10904)
  use foundation classes instead of default html validation (#10921)
  Fix failings redesign specs
  Add gitpod support (#10641)
  Fix pipeline after #10409 (#10670)
  Upgrade webpack and other javascript libraries (#10643)
  New Crowdin updates (#10409)
  Refactor attachment title (#10103)
  Fix for exporting hidden moderated proposals (#10630)
  Fix Exception as admin on a Proposal with meeting author (#10628)
  Fix: Deleted and hidden comments are exported (#10629)
  Rename "terms and conditions" to "terms of service" (#10614)
  Upgrade Graphql to 2.0.19 and Graphql-Api to 3.0.1 (#10606)
  Standardize the format of the words "they will" (#10617)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module: proposals type: fix PRs that implement a fix for a bug
Projects
Development

Successfully merging this pull request may close these issues.

Hidden moderated proposals are exported
3 participants