-
-
Notifications
You must be signed in to change notification settings - Fork 392
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for exporting hidden moderated proposals #10630
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andreslucena
changed the title
Fix: Hidden moderated proposals are exported
Fix for exporting hidden moderated proposals
Mar 28, 2023
andreslucena
previously requested changes
Mar 28, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can confirm that this is working locally. Just a string to fix and we're good to go
Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com>
alecslupu
moved this from Pending review from Product
to To Review by Core
in Maintainers
Mar 29, 2023
fblupi
approved these changes
Mar 29, 2023
alecslupu
dismissed
andreslucena’s stale review
March 29, 2023 12:22
The review recommendation has been implemented, Fran approved for maintainers
This was referenced Mar 31, 2023
entantoencuanto
added a commit
that referenced
this pull request
Jun 8, 2023
* feature/redesign: (70 commits) Fix failing specs Redesign sortitions (#10831) Redesign: data toggle (#10886) Redesign: collaborative drafts (#10729) Redesign: pending pages (#10944) Redesign: my account (#10904) use foundation classes instead of default html validation (#10921) Fix failings redesign specs Add gitpod support (#10641) Fix pipeline after #10409 (#10670) Upgrade webpack and other javascript libraries (#10643) New Crowdin updates (#10409) Refactor attachment title (#10103) Fix for exporting hidden moderated proposals (#10630) Fix Exception as admin on a Proposal with meeting author (#10628) Fix: Deleted and hidden comments are exported (#10629) Rename "terms and conditions" to "terms of service" (#10614) Upgrade Graphql to 2.0.19 and Graphql-Api to 3.0.1 (#10606) Standardize the format of the words "they will" (#10617) Fix the spec after word standardization (#10624) ...
entantoencuanto
added a commit
that referenced
this pull request
Jun 12, 2023
…blies-details-page * feature/redesign: (71 commits) Unskip tests (#10951) Fix failing specs Redesign sortitions (#10831) Redesign: data toggle (#10886) Redesign: collaborative drafts (#10729) Redesign: pending pages (#10944) Redesign: my account (#10904) use foundation classes instead of default html validation (#10921) Fix failings redesign specs Add gitpod support (#10641) Fix pipeline after #10409 (#10670) Upgrade webpack and other javascript libraries (#10643) New Crowdin updates (#10409) Refactor attachment title (#10103) Fix for exporting hidden moderated proposals (#10630) Fix Exception as admin on a Proposal with meeting author (#10628) Fix: Deleted and hidden comments are exported (#10629) Rename "terms and conditions" to "terms of service" (#10614) Upgrade Graphql to 2.0.19 and Graphql-Api to 3.0.1 (#10606) Standardize the format of the words "they will" (#10617) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
Currently, exports in Decidim will also expose the moderated content.
📌 Related Issues
Testing