Backport 'Fix Empty participatory process group is created when importing a PP …' to v0.27 #10732
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alecslupu
added
backport
alecslupu
force-pushed
the
backport/0.27/fix-empty-participatory-proces-10692
branch
3 times, most recently
from
99206b7
to
f0c9c8e
Compare
alecslupu
force-pushed
the
backport/0.27/fix-empty-participatory-proces-10692
branch
from
f0c9c8e
to
ea2069a
Compare
alecslupu
commented
Apr 19, 2023
| @@ -91,3 +91,6 @@ Rails/SkipsModelValidations: | |||
| Rails/Validation: | |||
| Include: | |||
| - decidim-*/app/models/**/*.rb | |||
|
|
|||
| Rails/CompactBlank: | |||
There was a problem hiding this comment.
This is disabled because compact_blank is a method available in later raiils versions ... and I got in a situation when I was trying to locally disable, but it errored with "Unecesary disable"... yet if i do not disable it, recommends to set:
translation.reject { |_k, v| v.blank? }
as
translation.compact_blank
Which will result in NoMethodError
There was a problem hiding this comment.
Thanks for the explanation!
andreslucena
approved these changes
Apr 25, 2023
andreslucena
deleted the
backport/0.27/fix-empty-participatory-proces-10692
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
Backport #10692 to v0.27