Backport 'Fix: Inconsistent datetime distance_in_words translations' to v0.26 #10795
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alecslupu
added
type: fix
alecslupu
force-pushed
the
fix/0.26-distance-in-words
branch
from
f74c858
to
c8f76ff
Compare
alecslupu
moved this from Pending review from Product
to Backport pending
in Maintainers
alecslupu
force-pushed
the
fix/0.26-distance-in-words
branch
2 times, most recently
from
cfdc2e8
to
82026e4
Compare
ahukkanen
requested changes
May 2, 2023
There was a problem hiding this comment.
Like I mentioned in the 0.27 counterpart review (#10793), I would think if we could implement this without causing so many changes, i.e. removing and adding new translations. I am not so much worried about the code level changes done here (which make sense) but more about the changes done in the translations structure.
Also, I believe there is one bug, as mentioned in the #10793 review.
alecslupu
force-pushed
the
fix/0.26-distance-in-words
branch
from
82026e4
to
e56f868
Compare
alecslupu
changed the title
alecslupu
added
backport
ahukkanen
approved these changes
May 4, 2023
andreslucena
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
馃帺 What? Why?
Backport #10810 to v0.26