Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport 'Fix File attachments in proposals' to v0.27 #10827

Merged
merged 1 commit into from May 11, 2023
Merged

Backport 'Fix File attachments in proposals' to v0.27 #10827

merged 1 commit into from May 11, 2023

Conversation

alecslupu
Copy link
Contributor

馃帺 What? Why?

Backport #10290 to v0.27

鈾ワ笍 Thank you!

@alecslupu alecslupu added backport Pull Requests that are a backport for a fixed bug module: core module: proposals release: v0.27 Issues or PRs that need to be tackled for v0.27 type: fix PRs that implement a fix for a bug labels May 8, 2023
@alecslupu alecslupu force-pushed the backport/0.27/fix-file-attachments-in-propos-10290 branch from 1c6e8dc to 9fc50d3 Compare May 8, 2023 09:34
@alecslupu alecslupu mentioned this pull request May 8, 2023
Closed
@alecslupu alecslupu added this to Pending review from Product in Maintainers via automation May 8, 2023
@alecslupu alecslupu moved this from Pending review from Product to Backport pending in Maintainers May 8, 2023
@alecslupu alecslupu linked an issue May 8, 2023 that may be closed by this pull request
Can't upload an attachment to proposal from backend as an admin in 0.27.2 #10825
Closed
@alecslupu alecslupu force-pushed the release/0.27-stable branch 8 times, most recently from e9ef8b6 to 9ce0ed4 Compare May 10, 2023 17:57
@alecslupu
Fix File attachments in proposals
20a9657 
* Fix File attachments in proposals

* Fixing Failing specs
@alecslupu alecslupu force-pushed the backport/0.27/fix-file-attachments-in-propos-10290 branch from 9fc50d3 to 20a9657 Compare May 10, 2023 18:05
ahukkanen
ahukkanen approved these changes May 11, 2023
View reviewed changes
Copy link
Contributor

@ahukkanen ahukkanen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The failing spec has been fixed by #10843, so I will go ahead and approve this one.

It should pass when merged to the release branch as that other PR was already merged.

@ahukkanen ahukkanen merged commit f028c1e into release/0.27-stable May 11, 2023
42 of 43 checks passed
Maintainers automation moved this from Backport pending to Done May 11, 2023
@ahukkanen ahukkanen deleted the backport/0.27/fix-file-attachments-in-propos-10290 branch May 11, 2023 10:54
@alecslupu alecslupu added this to the 0.27.3 milestone Jul 14, 2023
@alecslupu alecslupu mentioned this pull request Jul 19, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahukkanen ahukkanen ahukkanen approved these changes

Assignees
No one assigned
Labels
backport Pull Requests that are a backport for a fixed bug module: core module: proposals release: v0.27 Issues or PRs that need to be tackled for v0.27 type: fix PRs that implement a fix for a bug
Projects
Maintainers
Done
Milestone
0.27.3
Development

Successfully merging this pull request may close these issues.

Can't upload an attachment to proposal from backend as an admin in 0.27.2
2 participants
@alecslupu @ahukkanen