Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport 'Fix default seeds on first login (password_updated_at and accepted_tos_version)' to v0.27 #10854

Merged
merged 1 commit into from
May 15, 2023
Merged

Backport 'Fix default seeds on first login (password_updated_at and accepted_tos_version)' to v0.27 #10854

merged 1 commit into from
May 15, 2023

Conversation

andreslucena
Copy link
Member

🎩 What? Why?

Backport #9482 to v0.27

♥️ Thank you!

@andreslucena
Fix default seeds on first login (password_updated_at and accepted_to…
a8996f9 
…s_version)

* Add password_updated_at attribute in admin seed

* Change accepted TOS version in seeds
@andreslucena andreslucena added backport Pull Requests that are a backport for a fixed bug module: admin module: core type: internal PRs that aren't necessary to add to the CHANGELOG for implementers labels May 15, 2023
@andreslucena
Copy link
Member Author

I know that as a policy we usually don't backport type: internal PRs, but in this change I want to have this on v0.27 for two reasons:

  1. On the past months, while developing a module on v0.27, every time that I regenerated the app to check the seeds, I had to change this password and it was a mini-pain
  2. It adds friction to newcomers: just imagine after being able to install decidim the first time, you're greeted with this first screen 😅

@alecslupu alecslupu added this to Pending review from Product in Maintainers via automation May 15, 2023
@alecslupu alecslupu moved this from Pending review from Product to Backport pending in Maintainers May 15, 2023
@alecslupu alecslupu merged commit e2fe9ae into release/0.27-stable May 15, 2023
43 checks passed
Maintainers automation moved this from Backport pending to Done May 15, 2023
@alecslupu alecslupu deleted the backport/0.27/fix-default-seeds-on-first-log-9482 branch May 15, 2023 12:02
@alecslupu alecslupu added this to the 0.27.4 milestone Jun 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alecslupu alecslupu alecslupu approved these changes

Assignees
No one assigned
Labels
backport Pull Requests that are a backport for a fixed bug module: admin module: core type: internal PRs that aren't necessary to add to the CHANGELOG for implementers
Projects
Maintainers
Done
Milestone
0.27.4
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@andreslucena @alecslupu