Fix budgets zero single view

[greenwoodt]

🎩 What? Why?

Component: Budgets

Budgets that were set to zero as an admin in the view would crash when a user wished to view them on the front end facing view.

A patch has been created in decidim-budgets/apps/models/decidim/budgera/order.rb in a form of a condition that takes this into account if the user wants a zero budget, allowing admins to view their budgets set at zero.

The validation has also been updated to take this into account within decidim-budgets/app/forms/decidim/budgets/admin/budget_form.rb

📌 Related Issues

Link your PR to an issue

• Fixes Budgets component's single budget view crashes if budget is set to zero #10710

Testing

1. Login as a admin
2. Head to edit under your admin acc
3. Click processes on the left and a select any open or create a new one.
4. Click budgets and create a new by pre-filling all the necessary information in the form.
5. Under the "Total Budget", make sure that value is set to 0.
6. Save this by "Create Budget" at the bottom of the form.
7. You'll be taken back to the index of the budgets available and you'll notice you'll have your new budget set at 0.
8. Preview this budget by clicking the eye icon on the right panel under actions.
9. You'll be taken to the front end view of your new budget set at zero.

Rspec tests have also been created for patch, currently raking green for the following:

• Budgets at zero patch: decidim-budgets/spec/system/orders_spec.rb
• Validation check: decidim-budgets/spec/forms/decidim/budgets/admin/budget_form_spec.rb

📷 Screenshots

♥️ Thank you!

[alecslupu]

This PR contains the work done in #10855 .

Please run on your local environment:

git checkout develop 
git pull origin develop 
git branch -D fix/budgets-zero-single-view
git checkout -b fix/budgets-zero-single-view
git cherry-pick 2dc51df20219d7cdb2cc6e99c4627da5182799ce
git push origin -f 

[greenwoodt]

@alecslupu thanks, I noticed when I pushed I had a previous PR's work following behind.

With regards to your suggestion on updating the patch, I have committed your suggestion. Thanks very much for your contribution.

[alecslupu]

@greenwoodt , Please see my last comment: Run in a terminal ( console ) the following commands.

git checkout develop 
git pull origin develop 
git branch -D fix/budgets-zero-single-view
git checkout -b fix/budgets-zero-single-view
git cherry-pick 2dc51df20219d7cdb2cc6e99c4627da5182799ce
git cherry-pick dec506c6cce520f57485c4904aac77f633a90f50
git push origin -f 

[greenwoodt]

hi @alecslupu I saw your initial comment ran that command and your new suggested one on my machine. Apologies I had to recommit your commented changes previously. The PR should be updated and ready for review.

[greenwoodt]

Changes made ready for review

[alecslupu]

LGTM ( tested locally and works as advertised )