New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Backport 'Fix notifications page when vapid is not available' to v0.27 #10940
Backport 'Fix notifications page when vapid is not available' to v0.27 #10940
Conversation
dcda433
to
fd5f703
Compare
* User's group endorsement no longer disappears after personal endorsement removed * Fixed group endorsement removal when personal endorsement removed & tests * test-fixes * Fix the notification settings when vapid keys are not present --------- Co-authored-by: JoonasAapro <110532525+JoonasAapro@users.noreply.github.com>
fd5f703
to
dd3bb5f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see that there are some changes that seems that have not relation to this particular PR (on .github/actions/module-rspec/action.yml
and also on the Gemfile.lock
files. Is that intentional? There was a failing spec related to those?
I don't know, @alecslupu has force pushed to this branch which overrides the original changes. Maybe Alex can take on this? |
On it. There were some issues on the rubocop side, and also on the Gemfile ... |
馃帺 What? Why?
Backport #10286 to v0.27