Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport 'Fix exception in Initiatives' Page' to v0.27 #11023

Conversation

alecslupu
Copy link
Contributor

馃帺 What? Why?

Backport #10928 to v0.27

鈾ワ笍 Thank you!

@alecslupu alecslupu added backport Pull Requests that are a backport for a fixed bug module: initiatives type: fix PRs that implement a fix for a bug labels Jun 14, 2023
@alecslupu alecslupu force-pushed the backport/0.27/fix-exception-in-initiatives-p-10928 branch from dec9c53 to f805e6c Compare June 14, 2023 11:28
@alecslupu alecslupu added this to the Release 0.27.4 milestone Jun 14, 2023
@alecslupu alecslupu force-pushed the backport/0.27/fix-exception-in-initiatives-p-10928 branch from f805e6c to e8975c3 Compare June 14, 2023 13:35
* Add spec for checking that the Page inside of an Initiative works

* Fix bug during creation of Initiatives

* Fix bug on seeding Initiatives

* Add one time action on RELEASE_NOTES with the fix

* Fix rubocop offense

* Fix rubocop offense

* Fix path and filename of the rake task

* Fix typo

Suggested on code review

Co-authored-by: Alexandru Emil Lupu <contact@alecslupu.ro>

* Add PR id in RELEASE_NOTES

Suggested on code review

Co-authored-by: Alexandru Emil Lupu <contact@alecslupu.ro>

---------

Co-authored-by: Alexandru Emil Lupu <contact@alecslupu.ro>
@alecslupu alecslupu force-pushed the backport/0.27/fix-exception-in-initiatives-p-10928 branch from e8975c3 to 5d2a21a Compare June 14, 2023 21:05
@alecslupu alecslupu added this to Pending review from Product in Maintainers via automation Jun 14, 2023
@alecslupu alecslupu moved this from Pending review from Product to Backport pending in Maintainers Jun 14, 2023
Copy link
Member

@andreslucena andreslucena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR needs a one time action made by the implementer:

### 3.7. Initiatives pages exception fix

It isn't here because we didn't have the RELEASE_NOTES.md file on this version, as it was introduced on #10031 (after cutting the releases). Can you add it to the CHANGELOG.md 馃檹馃徑 ?

Copy link
Member

@andreslucena andreslucena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some few changes in the changelog

CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
alecslupu and others added 2 commits June 15, 2023 13:27
Co-authored-by: Andr茅s Pereira de Lucena <andreslucena@users.noreply.github.com>
@andreslucena andreslucena merged commit 200aec4 into release/0.27-stable Jun 15, 2023
46 checks passed
Maintainers automation moved this from Backport pending to Done Jun 15, 2023
@andreslucena andreslucena deleted the backport/0.27/fix-exception-in-initiatives-p-10928 branch June 15, 2023 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Pull Requests that are a backport for a fixed bug module: initiatives type: fix PRs that implement a fix for a bug
Projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants