-
-
Notifications
You must be signed in to change notification settings - Fork 393
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Backport 'Fix exception in Initiatives' Page' to v0.27 #11023
Backport 'Fix exception in Initiatives' Page' to v0.27 #11023
Conversation
dec9c53
to
f805e6c
Compare
f805e6c
to
e8975c3
Compare
* Add spec for checking that the Page inside of an Initiative works * Fix bug during creation of Initiatives * Fix bug on seeding Initiatives * Add one time action on RELEASE_NOTES with the fix * Fix rubocop offense * Fix rubocop offense * Fix path and filename of the rake task * Fix typo Suggested on code review Co-authored-by: Alexandru Emil Lupu <contact@alecslupu.ro> * Add PR id in RELEASE_NOTES Suggested on code review Co-authored-by: Alexandru Emil Lupu <contact@alecslupu.ro> --------- Co-authored-by: Alexandru Emil Lupu <contact@alecslupu.ro>
e8975c3
to
5d2a21a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR needs a one time action made by the implementer:
Line 155 in 2e36b3d
### 3.7. Initiatives pages exception fix |
It isn't here because we didn't have the RELEASE_NOTES.md file on this version, as it was introduced on #10031 (after cutting the releases). Can you add it to the CHANGELOG.md 馃檹馃徑 ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some few changes in the changelog
Co-authored-by: Andr茅s Pereira de Lucena <andreslucena@users.noreply.github.com>
馃帺 What? Why?
Backport #10928 to v0.27