Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport 'Fix webpacker crashes on missing icons' to v0.26 #11045

Conversation

alecslupu
Copy link
Contributor

馃帺 What? Why?

Backport #9636 to v0.26

鈾ワ笍 Thank you!

@alecslupu alecslupu added backport Pull Requests that are a backport for a fixed bug module: core type: fix PRs that implement a fix for a bug labels Jun 15, 2023
@alecslupu alecslupu force-pushed the backport/0.26/fix-webpacker-crashes-on-missi-9636 branch from 6f6d35c to e54131d Compare June 15, 2023 12:02
@alecslupu alecslupu added this to the 0.26.8 milestone Jun 15, 2023
@alecslupu alecslupu added this to Pending review from Product in Maintainers via automation Jun 15, 2023
@alecslupu alecslupu moved this from Pending review from Product to Backport pending in Maintainers Jun 15, 2023
@andreslucena
Copy link
Member

@alecslupu codecov integration is hanged without timeout:

Screenshot of the codecov run in github actions

I don't see the way of cancelling. What do you think? Should we ignore this (as codecov is failing like 50% of times either way)? Or do you want to make an empty commit to trigger again the CI?

@alecslupu alecslupu force-pushed the backport/0.26/fix-webpacker-crashes-on-missi-9636 branch from e54131d to 9aa9fde Compare June 16, 2023 08:14
Copy link
Member

@andreslucena andreslucena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

馃憤馃徑

@andreslucena andreslucena merged commit a4fdc79 into release/0.26-stable Jun 19, 2023
48 checks passed
Maintainers automation moved this from Backport pending to Done Jun 19, 2023
@andreslucena andreslucena deleted the backport/0.26/fix-webpacker-crashes-on-missi-9636 branch June 19, 2023 04:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Pull Requests that are a backport for a fixed bug module: core type: fix PRs that implement a fix for a bug
Projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants