Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport 'Remove duplication of LastActivity queries' to v0.27 #11055

Merged
merged 1 commit into from Jun 19, 2023
Merged

Backport 'Remove duplication of LastActivity queries' to v0.27 #11055

merged 1 commit into from Jun 19, 2023

Conversation

alecslupu
Copy link
Contributor

馃帺 What? Why?

Backport #9895 to v0.27

鈾ワ笍 Thank you!

@alecslupu alecslupu added backport Pull Requests that are a backport for a fixed bug module: core type: internal PRs that aren't necessary to add to the CHANGELOG for implementers labels Jun 17, 2023
@alecslupu alecslupu added this to Pending review from Product in Maintainers via automation Jun 17, 2023
@alecslupu alecslupu moved this from Pending review from Product to Backport pending in Maintainers Jun 17, 2023
@alecslupu alecslupu added this to the 0.27.4 milestone Jun 17, 2023
@alecslupu alecslupu force-pushed the backport/0.27/remove-duplication-of-lastacti-9895 branch from 0a791de to 1a1483b Compare June 17, 2023 10:15
@alecslupu alecslupu force-pushed the backport/0.27/remove-duplication-of-lastacti-9895 branch from 1a1483b to cf8f1e6 Compare June 17, 2023 10:37
andreslucena
andreslucena approved these changes Jun 19, 2023
View reviewed changes
Copy link
Member

@andreslucena andreslucena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code-wise LGTM, but do we need this on v0.27 for some reason? I'm almost sure that we've talked about this one last week, but as it's a type: internal I'd said that we should probably don't merge this, unless it's necessary to other PR. (As I'm like 80% sure that's the case, but I don't find the reference :/)
So, I'll leave this approved in case you need it but if you can share the reference that'd be great. If it isn't necessary for other backport, I'd prefer to not merge this (even though it shouldn't hurt, but just in case)

@alecslupu
Copy link
Contributor Author

@andreslucena , last week we discussed about not pursue with #11044 backport, which is related to 0.26.

Currently, i need to backport this particular PR as it is introducing the LastActivity class, which is further required in backporting #10385 into 0.27 .

@alecslupu
Copy link
Contributor Author

@andreslucena I am mergin this as we need it to move forward backporting #10385 into 0.27

@alecslupu alecslupu merged commit 6d2a4de into release/0.27-stable Jun 19, 2023
46 checks passed
Maintainers automation moved this from Backport pending to Done Jun 19, 2023
@alecslupu alecslupu deleted the backport/0.27/remove-duplication-of-lastacti-9895 branch June 19, 2023 05:22
@andreslucena
Copy link
Member

Ah ok, of course! I have the memory of a fish and Monday's morning I'm specially slowish 馃槄

@alecslupu alecslupu mentioned this pull request Jul 19, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andreslucena andreslucena Awaiting requested review from andreslucena

Assignees
No one assigned
Labels
backport Pull Requests that are a backport for a fixed bug module: core type: internal PRs that aren't necessary to add to the CHANGELOG for implementers
Projects
Maintainers
Done
Milestone
0.27.4
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@alecslupu @andreslucena