Backport 'Fix issues with overriding maps and loading Leaflet' to v0.27 #11131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fix issues with overriding maps and loading Leaflet * Remove commented configuration * Prevent external requests during the custom map spec * Test that the custom map also shows the marker correctly * Correct the dummy tiles route for OSM maps * Apply review recommendations
andreslucena
added
backport
|
@andreslucena could you have a look here ? |
|
@andreslucena Can I take on this and #11132? There are some differences how assets are handled in 0.26 and 0.27 since the switch to Shakapacker and the changes in the map providers, so this needs a bit more work to make it work properly at 0.27 and 0.26. |
|
@ahukkanen go ahead! I didn't have time to focus on these two backports. I'll assign them to you |
|
@alecslupu Pipeline is green here as well. |
|
And just to be sure I also tested it out according to the original testing instructions at #11105 in both versions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
馃帺 What? Why?
Backport #11105 to v0.27