Remove webpacker hack which is no longer needed #11141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahukkanen
added
the
type: internal
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
馃帺 What? Why?
While I was debugging some webpacker related issues, I noticed that we still have this hack in place that was added at #9203.
Since #10389 this is no longer needed.
I will leave the spec in place so that we won't hit this issue again, as long as we are using webpacker/shakapacker.
Tagging this as
internalbecause it does not have to be backported since it concerns only the upcoming version 0.28.馃搶 Related Issues
Testing
Run the spec that was added at #9203 to test that it is still working properly after this removal: