New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
CSV & JSON export function fix #11145
CSV & JSON export function fix #11145
Conversation
@greenwoodt , if you have finished working on it, please make sure it does not remain in draft state. |
Not quite done yet Alex. Other finished PR's still require my attention. Will convert from draft when its ready. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested locally, and works as advertised.
馃帺 What? Why?
The modules in Initiatuves, Consultations and Votings export function in specific components did not work and upon an attempted export, created a 404 error. This fix creates an
exports_controller.rb
file in the coorispionding modules and updates thepermissions.rb
file, to allow an admin user to export correctly.馃搶 Related Issues
Link your PR to an issue
Testing
The
exports_controller.rb
for elections/votings and initiatives have a rspec testing file you can call:decidim-elections/spec/controllers/decidim/votings/exports_controller_spec.rb
decidim-initiatives/spec/controllers/decidim/initiatives/admin/exports_controller_spec.rb
馃摲 Screenshots