Backport 'Nullable component setting generates error :comments_max_length' to v0.27 #11239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alecslupu
added
backport
alecslupu
force-pushed
the
backport/0.27/nullable-component-setting-gen-10561
branch
from
b29c257
to
18f4682
Compare
* Fix: Empty proposals config limits * Make comments_max_length mandatory in accountability Make comments_max_length mandatory in blogs Add default value for comments_max_length Make comments_max_length mandatory in debates Make comments_max_length mandatory in budgets Make comments_max_length mandatory in meeetings Make comments_max_length mandatory in sortitions Running linters * Change the factory * Fixing factory * Remove the default value of comments_max_length * Add to_i statements and tests * Mark Comments max length as required in the interface * Apply suggestions from code review Co-authored-by: Antti Hukkanen <antti.hukkanen@mainiotech.fi> * Add comments_max_length default, set validator to greater_than_or_equal_to --------- Co-authored-by: Antti Hukkanen <antti.hukkanen@mainiotech.fi>
alecslupu
force-pushed
the
backport/0.27/nullable-component-setting-gen-10561
branch
from
18f4682
to
1e86426
Compare
fblupi
approved these changes
Aug 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
馃帺 What? Why?
Backport #10561 to v0.27