Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport 'Fix HTML titles in admin panel' to v0.27 #11333

Conversation

andreslucena
Copy link
Member

🎩 What? Why?

Backport #10976 to v0.27

♥️ Thank you!

* process pages with html titles in crud

* Assemblies index and edit added

* Assemblies types HTML page tag added

* Assemblies settings HTML title added

* Initiative pages with new HTML titles

* Assemblies CRUD pages with HTML titles

* Voting module with HTML titles added

* Consultations module with HTML titles added

* Responses html titles in crud of Consultations module added

* Spacing issue with responses

* Conferences with HTML titles added

* Global moderations HTML tags added

* Static pages index and new added with HTML titles

* Edit to static pages HTML title added

* Page topics HTML titles added

* Participants HTML titles added

* Participatory process clean up & Participtory group type NEW bug fix

* Newsletters with html titles added

* settings HTML titles added

* templates html titles added

* i18n locales EN fix

* Fixing spacing with Votings

* Minor change to conference partner edit

* Minor changes to EDIT to decidim-conferences certificate of attendance + registeration types

* Change to media_link EDIT on conferences

* Change to user_roles EDIT conference admins

* Update decidim-admin/app/views/decidim/admin/help_sections/show.erb

Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com>

* Apply suggestions from code review

Reviewed and committed.

Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com>

* edit asseembly type to title in decidim-assemblies locales EN

* Apply suggestions from code review

Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com>

* Apply suggestions from code review

Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com>

* Update to decidim-admin title USERS/NEW

* Bundle exec i18n-task update

* Updated i18n translations on help_sections + impersionations

* Clean up of unused translations in decidim-admin locales/en.yml

* Updated pages with inherited H2 titles

* Apply suggestions from code review

Co-authored-by: Alexandru Emil Lupu <contact@alecslupu.ro>
Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com>

* Updated the unused i18n Locales for each module

* Clean up of area_types

* Update decidim-admin/app/views/decidim/admin/conflicts/index.html.erb

Co-authored-by: Alexandru Emil Lupu <contact@alecslupu.ro>

* Update decidim-admin/app/views/decidim/admin/static_pages/edit.html.erb

Co-authored-by: Alexandru Emil Lupu <contact@alecslupu.ro>

* Update decidim-admin/app/views/layouts/decidim/admin/global_moderations.html.erb

Co-authored-by: Alexandru Emil Lupu <contact@alecslupu.ro>

* Update decidim-assemblies/app/views/decidim/assemblies/admin/assemblies/new.html.erb

Co-authored-by: Alexandru Emil Lupu <contact@alecslupu.ro>

* Update decidim-assemblies/app/views/decidim/assemblies/admin/assemblies_settings/edit.html.erb

Co-authored-by: Alexandru Emil Lupu <contact@alecslupu.ro>

* Update decidim-conferences/app/views/decidim/conferences/admin/conference_invites/index.html.erb

Co-authored-by: Alexandru Emil Lupu <contact@alecslupu.ro>

* Update decidim-conferences/app/views/decidim/conferences/admin/conference_speakers/edit.html.erb

Co-authored-by: Alexandru Emil Lupu <contact@alecslupu.ro>

* Update decidim-elections/app/views/decidim/votings/admin/votings/index.html.erb

Co-authored-by: Alexandru Emil Lupu <contact@alecslupu.ro>

* Update decidim-initiatives/app/views/decidim/initiatives/admin/initiatives_settings/edit.html.erb

Co-authored-by: Alexandru Emil Lupu <contact@alecslupu.ro>

* Final changes and updates to i18n translations

* Update decidim-consultations/app/views/decidim/consultations/admin/responses/new.html.erb

Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com>

* Update decidim-consultations/app/views/decidim/consultations/admin/consultations/new.html.erb

Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com>

* Update decidim-consultations/app/views/decidim/consultations/admin/questions/new.html.erb

Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com>

* Final changes to the i18n translations

* Update decidim-assemblies/app/views/decidim/assemblies/admin/assemblies_types/edit.html.erb

Co-authored-by: Alexandru Emil Lupu <contact@alecslupu.ro>

* Update decidim-assemblies/app/views/decidim/assemblies/admin/assemblies_types/new.html.erb

Co-authored-by: Alexandru Emil Lupu <contact@alecslupu.ro>

* Update decidim-conferences/app/views/decidim/conferences/admin/conference_copies/new.html.erb

Co-authored-by: Alexandru Emil Lupu <contact@alecslupu.ro>

* Final 2nd round updates to i18n files

* Update decidim-participatory_processes/app/views/decidim/participatory_processes/admin/participatory_process_copies/new.html.erb

---------

Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com>
Co-authored-by: Alexandru Emil Lupu <contact@alecslupu.ro>
@andreslucena andreslucena added backport Pull Requests that are a backport for a fixed bug module: admin type: fix PRs that implement a fix for a bug labels Jul 24, 2023
@andreslucena andreslucena requested a review from a team July 24, 2023 16:09
Copy link
Contributor

@alecslupu alecslupu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alecslupu alecslupu added this to Pending review from Product in Maintainers via automation Jul 24, 2023
@alecslupu alecslupu added this to the 0.27.4 milestone Jul 24, 2023
@alecslupu alecslupu merged commit 5eca9d5 into release/0.27-stable Jul 25, 2023
37 of 38 checks passed
Maintainers automation moved this from Pending review from Product to Done Jul 25, 2023
@alecslupu alecslupu deleted the backport/0.27/fix-html-titles-in-admin-panel-10976 branch July 25, 2023 04:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Pull Requests that are a backport for a fixed bug module: admin type: fix PRs that implement a fix for a bug
Projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants