Refactor dispatched events in participatory space user roles #11338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alecslupu
added
target: developer-experience
no-backport
alecslupu
force-pushed
the
feature/align-command-api
branch
from
ebb734f
to
d375858
Compare
ahukkanen
approved these changes
Jul 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
馃帺 What? Why?
When we have implemented #11117, we did not had available the "with_events" api, therefore we have used a simple dispatch event. Considering the changes added in #11064, we aim to have the same api, to offer consistency across the project.
馃搶 Related Issues
Link your PR to an issue
Testing
Describe the best way to test or validate your PR.
馃摲 Screenshots
Please add screenshots of the changes you are proposing
