Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport "Lock ChromeDriver to the latest working version" to v0.27 #11392

Merged

Conversation

alecslupu
Copy link
Contributor

馃帺 What? Why?

Currently the pipelines are failing due to a nev version of chromedriver being shipped. This PR locks the chromedriver to the last known working version, so that we can avoid being blocked by issue.

##setup chromedriver
/home/runner/work/_actions/nanasess/setup-chromedriver/v2/lib/setup-chromedriver.sh  linux64
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed

  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
  0   193    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
curl: (22) The requested URL returned error: 404
Error: The process '/home/runner/work/_actions/nanasess/setup-chromedriver/v2/lib/setup-chromedriver.sh' failed with exit code 22

馃搶 Related Issues

Link your PR to an issue

Testing

Make sure the pipeline is green

馃摲 Screenshots

Please add screenshots of the changes you are proposing
Description

鈾ワ笍 Thank you!

@alecslupu alecslupu added the release: v0.27 Issues or PRs that need to be tackled for v0.27 label Jul 26, 2023
@alecslupu alecslupu self-assigned this Jul 26, 2023
@andreslucena andreslucena changed the title Lock ChromeDriver to the latest working version Backport "Lock ChromeDriver to the latest working version" to v0.27 Jul 26, 2023
@andreslucena
Copy link
Member

I'm changing the title to a backport format, so it's easier to see the difference with #11391 (and also we should probably add it to v0.26 too, so that'd be yet another PR that we need to differentiate

@alecslupu
Copy link
Contributor Author

Since this PR is based on #11352

Failing spec is expected, as the documentation says:

Wait for the tests to finish and check that everything is passing before releasing the version. NOTE: When you bump the version, the generator tests will fail because the gems and NPM packages have not been actually published yet (as in sent to rubygems/npm). You may see errors such as No matching version found for @decidim/browserslist-config@~0.xx.y in the CI logs. This should be fine as long as you have ensured that the generators tests passed in the previous commit.

@alecslupu alecslupu added the type: internal PRs that aren't necessary to add to the CHANGELOG for implementers label Jul 26, 2023
@andreslucena
Copy link
Member

Merging this one as the failing spec is expected

@andreslucena andreslucena merged commit 86b25c6 into release/0.27-stable Jul 26, 2023
45 of 46 checks passed
@andreslucena andreslucena deleted the chore/fix-chromedriver-in-release027 branch July 26, 2023 13:39
@alecslupu alecslupu added this to the 0.27.4 milestone Jul 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release: v0.27 Issues or PRs that need to be tackled for v0.27 type: internal PRs that aren't necessary to add to the CHANGELOG for implementers
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants