Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use with_any_scope instead of with_scope for assemblies and processes #11438

Merged
merged 7 commits into from
Oct 11, 2023

Conversation

fblupi
Copy link
Member

@fblupi fblupi commented Aug 2, 2023

🎩 What? Why?

Use with_any_scope instead of with_scope for assemblies and processes.

📌 Related Issues

Testing

  1. Go to processes or assemblies
  2. Filter by scope
  3. Filter by another scope
  4. Check the page loads successfully
  5. Access again the page reloading with the URL with the two filters and see the page loads successfully

♥️ Thank you!

Copy link
Contributor

@alecslupu alecslupu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have checked and the fix as advertised, Yet there are some fixes that could be done in this part.

@alecslupu
Copy link
Contributor

I have checked and the fix as advertised, Yet there are some fixes that could be done in this part.

Scenario 1:

  1. visit an assembly or Participatory process.
  2. When you refresh the entire page, the filter pill is dissapearing:
    image
    vs
    image

Scenario 2:

  1. Visit participatory space
  2. Select any scope that does not have anything assigned
  3. See the message "There are no active nor upcoming processes. Here is a list of the past ones." is being displayed
  4. Go to scope filter and choose a scope that has something into it ...
  5. See the message and a process card are being displayed

image

@fblupi
Copy link
Member Author

fblupi commented Aug 11, 2023

I have checked and the fix as advertised, Yet there are some fixes that could be done in this part.

Hi @alecslupu, I have fixed the issues you mentioned. Let's wait until the pipeline is green and review it again 🙂

@fblupi fblupi requested a review from alecslupu August 11, 2023 15:22
@fblupi fblupi changed the title Use with_any_scope instead of with_scope for assemblies and processes Use with_any_scope instead of with_scope for assemblies and processes Aug 11, 2023
@alecslupu alecslupu added the release: v0.27 Issues or PRs that need to be tackled for v0.27 label Oct 5, 2023
Copy link
Contributor

@alecslupu alecslupu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alecslupu alecslupu added this to the 0.27.5 milestone Oct 5, 2023
@alecslupu
Copy link
Contributor

Merging as per my previous approval.

@alecslupu alecslupu merged commit 3637c22 into release/0.27-stable Oct 11, 2023
47 checks passed
@alecslupu alecslupu deleted the fix/11413 branch October 11, 2023 12:20
@andreslucena andreslucena added the no-backport Pull Requests that should not be backported label Nov 2, 2023
@andreslucena
Copy link
Member

Adding the "no-backport" label as this can't be reproduced in v0.28 and also it isn't in v0.26 (as this comes from the "Searchlight removal" change).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module: assemblies module: participatory processes no-backport Pull Requests that should not be backported release: v0.27 Issues or PRs that need to be tackled for v0.27 type: fix PRs that implement a fix for a bug
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Error accessing processes or assemblies via URL with multiple filters by scope
3 participants