-
-
Notifications
You must be signed in to change notification settings - Fork 395
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use with_any_scope
instead of with_scope
for assemblies and processes
#11438
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have checked and the fix as advertised, Yet there are some fixes that could be done in this part.
Hi @alecslupu, I have fixed the issues you mentioned. Let's wait until the pipeline is green and review it again 🙂 |
with_any_scope
instead of with_scope
for assemblies and processes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Merging as per my previous approval. |
Adding the "no-backport" label as this can't be reproduced in v0.28 and also it isn't in v0.26 (as this comes from the "Searchlight removal" change). |
🎩 What? Why?
Use
with_any_scope
instead ofwith_scope
for assemblies and processes.📌 Related Issues
Testing