Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport 'Encode non-ASCII characters on external links' to v0.27 #11499

Merged
merged 1 commit into from
Aug 21, 2023
Merged

Backport 'Encode non-ASCII characters on external links' to v0.27 #11499

merged 1 commit into from
Aug 21, 2023

Conversation

fblupi
Copy link
Member

@fblupi fblupi commented Aug 21, 2023

馃帺 What? Why?

Backport #11472 to v0.27

鈾ワ笍 Thank you!

@fblupi
Encode non-ASCII characters on external links (#11472)
6d89092 
* Encode non-ASCII characters on external links

* Lint

* Apply suggestions
@fblupi fblupi added module: core backport Pull Requests that are a backport for a fixed bug type: fix PRs that implement a fix for a bug labels Aug 21, 2023
@fblupi fblupi requested a review from a team August 21, 2023 06:40
@alecslupu alecslupu added this to the 0.27.5 milestone Aug 21, 2023
alecslupu
alecslupu approved these changes Aug 21, 2023
View reviewed changes
Copy link
Contributor

@alecslupu alecslupu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alecslupu alecslupu merged commit 60368ee into release/0.27-stable Aug 21, 2023
45 of 46 checks passed
@alecslupu alecslupu deleted the backport/0.27/econde-non-ascii-characters-on-11472 branch August 21, 2023 17:24
@andreslucena andreslucena mentioned this pull request Nov 6, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alecslupu alecslupu alecslupu approved these changes

Assignees
No one assigned
Labels
backport Pull Requests that are a backport for a fixed bug module: core type: fix PRs that implement a fix for a bug
Projects
Maintainers' backlog
Archived in project
Milestone
0.27.5
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@fblupi @alecslupu