Extraction of i18n strings in system panel

[greenwoodt]

🎩 What? Why?

Extracting and adding i18n translations to system docs where needed, making the use of strings not needed.

📌 Related Issues

Link your PR to an issue

• Related to #?
• Fixes Extract I18n strings from templates  #11481

Testing

📷 Screenshots

♥️ Thank you!

[alecslupu]

@greenwoodt this pr is not complete, as there are more strings to be extracted. Please see all the comments in the ticket

[greenwoodt]

@greenwoodt this pr is not complete, as there are more strings to be extracted. Please see all the comments in the ticket

I'm fully aware @alecslupu thanks. I'll notify you for a review once it is.

[greenwoodt]

@alecslupu I have changed and added translations according to your request on issue: #11481, however there was one I was stuck with on adding as the string does interpolate a class variable, located here: decidim-system/app/views/decidim/system/devise/shared/_links.html.erbon line 23.

I wondered whether you could provide insight on changing this? Does one at the interploation on the locales.en file directly and just call the translation?

[greenwoodt]

I have reverted line 12 back to Decidim here: decidim-system/app/views/layouts/decidim/system/login.html.erbas it was failing tests to do with yield and not being able to find the translation.

[andreslucena]

@alecslupu I have changed and added translations according to your request on issue: #11481, however there was one I was stuck with on adding as the string does interpolate a class variable, located here: decidim-system/app/views/decidim/system/devise/shared/_links.html.erbon line 23.

I wondered whether you could provide insight on changing this? Does one at the interploation on the locales.en file directly and just call the translation?

Check the Rails docs section. It's like this:

 t(".sign_in_with", provider: OmniAuth::Utils.camelize(provider))

And then in the relevant en.yml section:

sign_in_with: Sign in with %{provider}

But giving a second look to the feature itself, I'd said that we should remove this altogether, as:

1. In the context of Decidim, I can't imagine an instance that would want to enable omniauth for the system panel
2. Even if it does, this would never work, as it's referring to the current_organization helper that is not available in /system

So, its safe to remove this whole block:

 <%- if devise_mapping.omniauthable? %>
   <%- current_organization.enabled_omniauth_providers.keys.each do |provider| %>
     <%= link_to "Sign in with #{OmniAuth::Utils.camelize(provider)}", omniauth_authorize_path(resource_name, provider) %>
   <% end -%>
 <% end -%>

Can you do that @greenwoodt ? Thanks

[andreslucena]

I have reverted line 12 back to Decidim here: decidim-system/app/views/layouts/decidim/system/login.html.erbas it was failing tests to do with yield and not being able to find the translation.

What if we add the string that's missing in the en.yml file? I'm referring to this one:

Translation missing: en.layouts.decidim.shared.layout_center.decidim

[greenwoodt]

I have reverted line 12 back to Decidim here: decidim-system/app/views/layouts/decidim/system/login.html.erbas it was failing tests to do with yield and not being able to find the translation.

What if we add the string that's missing in the en.yml file? I'm referring to this one:

Translation missing: en.layouts.decidim.shared.layout_center.decidim

The file still fails a test, even after adding the string manually. I can try again today and let you know.

[alecslupu]

There is one key that should not be as it is.

[alecslupu]

@greenwoodt , please check also : decidim-system/app/views/decidim/system/devise/shared/_links.html.erb Line 2 ( there is a "Log in" left befind)

#11478 (comment)

[andreslucena]

I've just checked out all the comments from the original issue and I found a missing one:
#11478 (comment)

Regarding the rest, codewise is 🆗

[andreslucena]

Sorry, wrong button 😅
Can you check my last review? 🙏🏽

[greenwoodt]

Sorry, wrong button 😅 Can you check my last review? 🙏🏽

No worries! Check my comment here regarding this change that didn't work. I left it out purposefully as it was causing errors to the tests.

[alecslupu]

Sorry, wrong button 😅 Can you check my last review? 🙏🏽

No worries! Check my comment here regard this change that didn't work. I left it out purposefully as it was causing errors to the tests.

I have checked 66fc58d, and it seems that you have forgot to add it to en.yml file. it should work without any kind of issues, once you add layouts.decidim.shared.layout_center.decidim key to the en.yml.

As as alternative you could define it as decidim in the scope of decidim.system.titles like this: <%= t("decidim", scope: "en.decidim.system.titles") %>

[greenwoodt]

@alecslupu @andreslucena updated and ready.

[alecslupu]

LGTM

The PR is fairly simple, and I already reviewed it.