Fix duplicated endorsements

[alecslupu]

🎩 What? Why?

This PR tries to fix a concurrency issue that happens in endorsements. As per PostgreSQL documentation, null values in a unique column are not considered equal, allowing multiple nulls in the column.

Testing

1. Try to do multiple endorsements in the same proposal with the same user. See that you can't do that
2. Before patching, make the multiple endorsements. Then run bundle exec rails decidim:upgrade:fix_duplicate_endorsements

♥️ Thank you!

[andreslucena]

I tried it locally and it seems like it fixed this problem.

I think we should add a rake task with a comment in the RELEASES_NOTES to fix the (possible) cases where there's more than one endorsement. What do you think?

[andreslucena]

It's preventing the issue with the more than one endorsement with the same user in the same resource, so on that side 🆗

Regarding the rake task, I think it's messing with the functionality, as it isn't allowing me to "Unlike" after I've liked:

And when I click in my username in the modal, I see that the server is responding with 422 errors.

What I would expect is to see the "green"/selected identity in that modal, and then to be able to "unlike" it (and like it again).

Can you check that out please?

[alecslupu]

It's preventing the issue with the more than one endorsement with the same user in the same resource, so on that side 🆗

Regarding the rake task, I think it's messing with the functionality, as it isn't allowing me to "Unlike" after I've liked:

And when I click in my username in the modal, I see that the server is responding with 422 errors.

What I would expect is to see the "green"/selected identity in that modal, and then to be able to "unlike" it (and like it again).

Can you check that out please?

@andreslucena I have checked this, and I could not find anything wrong with it. There caching issue.
The scenario I have tested is the following:

• Visited a Proposal
• Endorsed
• Applied the patch
• Refreshed the page ( for some reason, in the first few refreshes I was being listed in endorsers list, yet, i could press Like)
• After i got enough refreshes ... eventually i have been able to see the Dislike button ..

Can you check that is not the same case on your end?
Also, could you also make sure you restart the server before actually trying to like / dislike ?

[andreslucena]

There caching issue.

Bitten by the cache, once again!

[andreslucena]

👍🏽

[andreslucena]

Only failing check is Codecov as usual, so I'm merging this

[alecslupu]

There caching issue.

Bitten by the cache, once again!

And I got bitten by proper English grammar :(