Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport 'Fix autocomplete result list duplicates' to v0.26 #11893

Conversation

andreslucena
Copy link
Member

@andreslucena andreslucena commented Nov 2, 2023

馃帺 What? Why?

Backport #11442 to v0.26

Note for reviewer

The bug can't be reproduced as it was introduced by the refactors of autocompletes (#8524) available since v0.27. Just to be sure I'm backporting (and adapting) the spec

鈾ワ笍 Thank you!

* Fix autocomplete user group duplication / Add system test

* Fix test
@andreslucena andreslucena added backport Pull Requests that are a backport for a fixed bug module: core type: fix PRs that implement a fix for a bug labels Nov 2, 2023
@alecslupu alecslupu added this to the 0.26.9 milestone Nov 2, 2023
@andreslucena
Copy link
Member Author

@alecslupu only failing spec is solved with #11906, so this can be merged as is IMO. If you want me to merge against the release branch after merging that one first just to be sure, let me know.

Copy link
Contributor

@alecslupu alecslupu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

馃憤

Merging

@alecslupu alecslupu merged commit 1907fb7 into release/0.26-stable Nov 3, 2023
48 of 49 checks passed
@alecslupu alecslupu deleted the backport/0.26/fix-autocomplete-result-list-d-11442 branch November 3, 2023 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Pull Requests that are a backport for a fixed bug module: core type: fix PRs that implement a fix for a bug
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants