Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport 'Deletion of leftovers ZIP files in tmp directory' to v0.26 #11898

Conversation

andreslucena
Copy link
Member

馃帺 What? Why?

Backport #11527 to v0.26

鈾ワ笍 Thank you!

* added method to delete tmp zip at end of job

* Space added on comment

* Rspec test added to test deletion

* Fixing the regex based rubocop suggestion
@andreslucena andreslucena added backport Pull Requests that are a backport for a fixed bug module: core type: fix PRs that implement a fix for a bug labels Nov 2, 2023
@alecslupu alecslupu added this to the 0.26.9 milestone Nov 2, 2023
Copy link
Contributor

@alecslupu alecslupu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a spec failing, as the download_your_data has been implemented in #9196

Co-authored-by: Alexandru Emil Lupu <contact@alecslupu.ro>
Copy link
Contributor

@alecslupu alecslupu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

馃憤

@alecslupu alecslupu merged commit 6e2088a into release/0.26-stable Nov 3, 2023
3 checks passed
@alecslupu alecslupu deleted the backport/0.26/deletion-of-leftovers-zip-file-11527 branch November 3, 2023 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Pull Requests that are a backport for a fixed bug module: core type: fix PRs that implement a fix for a bug
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants