Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport 'Fix 'download your data' when there are comments on budgets' to v0.26 #11902

Conversation

andreslucena
Copy link
Member

馃帺 What? Why?

Backport #11531 to v0.26

鈾ワ笍 Thank you!

@andreslucena andreslucena added backport Pull Requests that are a backport for a fixed bug module: budgets module: comments type: fix PRs that implement a fix for a bug labels Nov 2, 2023
@alecslupu alecslupu added this to the 0.26.9 milestone Nov 2, 2023
@andreslucena
Copy link
Member Author

@alecslupu only failing spec is solved with #11906, so this can be merged as is IMO. If you want me to merge against the release branch after merging that one first just to be sure, let me know.

Copy link
Contributor

@alecslupu alecslupu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

馃憤

Merging with failing spec, already fixed in #11906

@alecslupu alecslupu merged commit 9ef9133 into release/0.26-stable Nov 3, 2023
46 of 48 checks passed
@alecslupu alecslupu deleted the backport/0.26/fix-download-your-data-when-th-11531 branch November 3, 2023 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Pull Requests that are a backport for a fixed bug module: budgets module: comments type: fix PRs that implement a fix for a bug
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants