Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport 'Fix empty address in conference's venues ' to v0.27 #11910

Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
15 changes: 15 additions & 0 deletions decidim-conferences/spec/system/conferences_spec.rb
Expand Up @@ -237,6 +237,21 @@
expect(page).to have_no_css(".statistic__number", text: "3")
end
end

context "when the conference has multiple meetings components" do
let!(:meetings_component) { create(:component, :published, participatory_space: conference, manifest_name: :meetings) }
let!(:other_meetings_component) { create(:component, :published, participatory_space: conference, manifest_name: :meetings) }

it "show meeting venues" do
create(:meeting, :published, :online, address: "", location_hints: nil, location: "", component: meetings_component)
create(:meeting, :published, :in_person, address: "", location_hints: nil, location: "", component: other_meetings_component)
create_list(:meeting, 3, :published, :in_person, component: meetings_component)

visit decidim_conferences.conference_path(conference)

expect(page).to have_css("#venues .mb-s", count: 3)
end
end
end
end
end
Expand Up @@ -5,8 +5,11 @@
<div class="row">
<div class="column medium-4">
<% meetings.each do |meeting_block| %>
<% next if meeting_block.first.empty? %>

<% meeting_block.last.each_with_index do |meeting, index| %>
<% next if index != 0 %>

<%== cell("decidim/conferences/conference_address", meeting) %>
<% end %>
<% end %>
Expand Down