Fix order proposals by comments and follows using the column instead of a subquery #11976
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
alecslupu
approved these changes
Nov 10, 2023
There was a problem hiding this comment.
Works as advertised.
There is an approval from me, but @andreslucena has the final say.
fblupi
changed the title
andreslucena
approved these changes
Nov 13, 2023
|
Only failing spec is codecov, so I'm ignoring it. |
fblupi
added a commit
that referenced
this pull request
Nov 13, 2023
…of a subquery (#11976) * Fix order by comments and follows using the column instead of a subquery * Add spec
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
First, I tried to fix it the same way I did with a similar issue (#11473) without any good result.
I tried a different solution and checked Proposals
orderable.rbfile. I saw it used a subquery to order by comments and follows instead of using the columns. These columns were created after the concern and maybe that's the cause it wasn't them.📌 Related Issues
Testing
📷 Screenshots
Screen.Recording.2023-11-09.at.17.21.01.mov