Fix shortlink references #12004
Merged
Fix shortlink references #12004
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
fblupi
requested changes
Nov 15, 2023
There was a problem hiding this comment.
Looks good and works fine! Just a small change to avoid the call to the EngineResolver and make the request some ms faster.
I would add a task to fix the broken short links too. I fixed the ones on Decidim Barcelona with a query checking the short link route name is "calendar", the target type is "Decidim::Component" and changes the mounted engine depending on which type of space is containing that component.
fblupi
approved these changes
Nov 15, 2023
fblupi
pushed a commit
that referenced
this pull request
Nov 15, 2023
* Fix shortlink references * Add rake task to fix data * Add release notes
fblupi
added a commit
that referenced
this pull request
Nov 15, 2023
* Fix shortlink references (#12004) * Fix shortlink references * Add rake task to fix data * Add release notes * Fix tests --------- Co-authored-by: Alexandru Emil Lupu <contact@alecslupu.ro>
|
No backporting to v0.26 as the ShortLink helper was introduced on v0.27 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
馃帺 What? Why?
This PR tries to fix the shortlink issues for the components.
馃搶 Related Issues
Link your PR to an issue
Testing