Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix using CTA image on promoted process group #12202

Merged

Conversation

andreslucena
Copy link
Member

🎩 What? Why?

On v0.27, when you have a process group with a CTA and the group is promoted, the promoted image uses the CTA image.

This breaks the user expectation, as this doesn't work like that in processes. This PR changes it so it behaves the same.

I could not reproduce it in v0.28

📌 Related Issues

Testing

  1. Sign in as admin
  2. Create a process group
  3. Add an image on it
  4. Go to the processes list http://localhost:3000/processes - See that it's using the image in the card
  5. Define an image in the landing page in the content block "Image, text and Call to Action button"
  6. Go to the processes list http://localhost:3000/processes - See that it's still using the same image in the card
  7. Make the process group promoted and save it
  8. Go to the processes list http://localhost:3000/processes - See that it's using the CTA image

♥️ Thank you!

@andreslucena andreslucena added type: fix PRs that implement a fix for a bug module: participatory processes labels Dec 19, 2023
@andreslucena andreslucena marked this pull request as ready for review December 20, 2023 08:54
Copy link
Contributor

@alecslupu alecslupu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@alecslupu alecslupu merged commit 2b70370 into release/0.27-stable Jan 3, 2024
21 checks passed
@alecslupu alecslupu deleted the fix/promoted-process-group-cta-image branch January 3, 2024 16:52
@andreslucena andreslucena added the no-backport Pull Requests that should not be backported label Jan 9, 2024
@andreslucena
Copy link
Member Author

Adding the no-backport label as this was a fix for v0.27 only. It isn't happening in v0.28 and v0.26 isn't supported anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module: participatory processes no-backport Pull Requests that should not be backported type: fix PRs that implement a fix for a bug
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants