Replace picmo with emoji-mart #12243
Conversation
alecslupu
added
the
type: change
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
alecslupu
added
dependencies
andreslucena
changed the title
There was a problem hiding this comment.
Really clean! I only have a couple changes to propose but are really small. I'd also open a gitpod for @carolromero so she can check it out just in case I'm missing something
decidim-core/lib/decidim/core/test/shared_examples/comments_examples.rb
Outdated
Show resolved
Hide resolved
decidim-core/lib/decidim/core/test/shared_examples/comments_examples.rb
Outdated
Show resolved
Hide resolved
|
I see it like this from my mobile phone: And I have to press it 2 or 3 times to show me the selector.. Do you guys see it fine from yours? |
Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com>
|
@alecslupu let me know when this is ready for another round |
@andreslucena , this is ready for another round. |
|
FYI seems like the responsive is fixed 🥳 |
Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com>
|
Only failing spec is the flaky from |
🎩 What? Why?
This PR replaces Picmo with Emoji-mart.
As of September 14, 2023, Picmo is no longer being maintained as stated on the official site: https://picmojs.com/
Caveats:
At the opening time, the Light template of emoji-mart is too light, impacting the Look and feel. I have tried to override the styles, to match the the Look and feel provided by picmo, but i have not been successful.
📌 Related Issues
Link your PR to an issue
Testing
📷 Screenshots
Please add screenshots of the changes you are proposing
Picmo:
Emoji-Mart:
