Backport 'Use relative JS imports to allow overrides' to v0.28 #12265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add eslint-plugin-no-relative-import-paths package * Add rootDir setting to eslint plugin to not add the module name in the path The only problem is that this works in the decidim-core module, but in others module we need to manually fix it. As currently the automatic fix applies to: - decidim-core: 40 - decidim-comments: 1 - rest of the modules: 0 I think we can live with this not-so-optimal solution. * Run eslint with --fix The command was /home/apereira/Work/decidim/decidim/decidim-api/app/packs/entrypoints/decidim_api_graphiql.js 82:3 error ReactDOM.render is deprecated since React 18.0.0, use createRoot instead, see https://reactjs.org/link/switch-to-createroot react/no-deprecated ✖ 1 problem (1 error, 0 warnings) And ignoring the only offense from other module that isn't decidim-core. * Manually fix relative import wrongly fixed by eslint * Manually remove other relative imports not detected by the eslint plugin * Rollback relative import in comments.component_for_testing.js
andreslucena
added
backport
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
Only failing spec is the flaky from |
alecslupu
deleted the
backport/0.28/use-relative-js-imports-to-all-12211
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
Backport #12211 to v0.28