Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport 'Implement breadcrumb menu in all admin pages' to v0.28 #12302

Conversation

alecslupu
Copy link
Contributor

馃帺 What? Why?

Backport #12197 to v0.28

鈾ワ笍 Thank you!

* Use add_breadcrumb_item_from_menu in admin controllers and space admins concerns

* Set menu manually in moderations to prevent leaking of counters HTML

* Remove unecessary class component-counter--off in sidebar menu

* Fix component counter for Global moderations sidebar menu

* Use add_breadcrumb_item_from_menu and also add the space name in the votings landing

* Fix rubocop offenses

* Add breadcrumb for votings' monitoring committee members

Detected on code review

* Fix bug with Categories displayed two times in process' breadcrumb

Detected on code review

* Add breadcrumb for pages' topics

Detected on code review

* Add breadcrumb for participants' verifications

Detected on code review

* Fix escaping characters in the breadcrumb items

* Fix breadcrumb in Scopes and Area types

* Fix sidebar active link bug in Scopes and Area types

* Add Authorizations in breadcrumb navigation

* Add Impersonations in breadcrumb navigation
@alecslupu alecslupu added backport Pull Requests that are a backport for a fixed bug type: fix PRs that implement a fix for a bug labels Jan 15, 2024
@alecslupu alecslupu requested a review from a team January 15, 2024 12:54
@andreslucena
Copy link
Member

Only failing spec is codecov

@andreslucena andreslucena merged commit dbd148e into release/0.28-stable Jan 15, 2024
88 of 89 checks passed
@andreslucena andreslucena deleted the backport/0.28/implement-breadcrumb-menu-in-a-12197 branch January 15, 2024 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Pull Requests that are a backport for a fixed bug type: fix PRs that implement a fix for a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants