Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport 'Restrict comments replies tree including polymorphism' to v0.27 #12305

Conversation

alecslupu
Copy link
Contributor

🎩 What? Why?

Backport #12088 to v0.27

♥️ Thank you!

* Add tests to check the 'Hide replies' message error

* Add a polymorphic option to restrict acts_as_tree lookup

* Avoid name conflict in test

* Add reference to source of code

* Move comment

Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com>

---------

Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com>
@alecslupu alecslupu added backport Pull Requests that are a backport for a fixed bug module: comments type: fix PRs that implement a fix for a bug labels Jan 15, 2024
@alecslupu alecslupu marked this pull request as draft January 15, 2024 11:17
@alecslupu alecslupu self-assigned this Jan 25, 2024
@alecslupu alecslupu added this to the 0.27.6 milestone Mar 19, 2024
@alecslupu alecslupu assigned andreslucena and unassigned alecslupu Mar 19, 2024
@alecslupu alecslupu marked this pull request as ready for review March 19, 2024 11:24
Copy link
Member

@andreslucena andreslucena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code-wise is 💯

I've just checked to see if I could reproduce the original bug and the fix and I can confirm it was indeed fixed.

Bug

Screenshot of the bug

Fix

Screenshot of the fix

@andreslucena
Copy link
Member

Merging with the only failing check from codecov

@andreslucena andreslucena merged commit 185ede9 into release/0.27-stable Apr 3, 2024
42 of 43 checks passed
@andreslucena andreslucena deleted the backport/0.27/restrict-comments-replies-tree-12088 branch April 3, 2024 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Pull Requests that are a backport for a fixed bug module: comments type: fix PRs that implement a fix for a bug
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants