Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add participatory text missing attribute #12330

Merged

Conversation

andreslucena
Copy link
Member

馃帺 What? Why?

There's a missing attribute in the participatory text import of v0.27. This PR fixes it.

馃搶 Related Issues

Testing

  1. Create a new Proposals component with Participatory texts enabled
  2. Add a new document in this component
  3. See that there isn't anymore the "Translation missing" error

馃摲 Screenshots

Screenshot of the fix in the button

Screenshot of the fix in the modal

鈾ワ笍 Thank you!

@andreslucena andreslucena added module: proposals type: fix PRs that implement a fix for a bug no-backport Pull Requests that should not be backported labels Jan 24, 2024
@alecslupu alecslupu added this to the 0.27.6 milestone Jan 25, 2024
Copy link
Contributor

@alecslupu alecslupu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

馃憤

Merging with Codecov failed pipeline.

@alecslupu alecslupu merged commit 3b232f6 into release/0.27-stable Feb 5, 2024
15 of 16 checks passed
@alecslupu alecslupu deleted the fix/participatory-text-missing-attribute branch February 5, 2024 15:58
@alecslupu
Copy link
Contributor

@andreslucena , shall we backport to 0.26 ?

@andreslucena
Copy link
Member Author

No, 26 is not supported anymore. We will only backport the fix for the bug that has broken 0.26.9 (the template initializer)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module: proposals no-backport Pull Requests that should not be backported type: fix PRs that implement a fix for a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing translation on v0.27 on modal for importing participatory texts.
2 participants