Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport 'Migrate hardcoded Manage menu in spaces' admin pages' to v0.28 #12333

Conversation

alecslupu
Copy link
Contributor

馃帺 What? Why?

Backport #12329 to v0.28

鈾ワ笍 Thank you!

* Migrate hardcoded Manage menu in assemblies' admin

* Migrate hardcoded Manage menu in initiatives' admin

* Migrate hardcoded Manage menu in processes' admin

* Collapse menus definitions in assemblies

* Rename method name to be consistent with others methods

* Collapse menus definitions in participatory processes

* Move menu definition to admin_engine in participatory processes

* Collapse menus definitions in initiatives

* Collapse menus definitions in admin

* Collapse menus definitions in conferences

* Collapse menus definitions in core

* Collapse menus definitions in votings

* Collapse menus definitions in templates

* Make consistent the initializers names

Suggested on code review

Co-authored-by: Alexandru Emil Lupu <contact@alecslupu.ro>

* Make the menus definitions consistent between spaces

- Same order in code and in UI
- Same naming

* Make consistent the attributes order in dropdown definition

---------

Co-authored-by: Alexandru Emil Lupu <contact@alecslupu.ro>
@alecslupu alecslupu added backport Pull Requests that are a backport for a fixed bug module: admin type: fix PRs that implement a fix for a bug labels Jan 25, 2024
@alecslupu alecslupu requested a review from a team January 25, 2024 13:19
@andreslucena
Copy link
Member

Only failing check is codecov

@andreslucena andreslucena merged commit 6597244 into release/0.28-stable Jan 26, 2024
107 of 108 checks passed
@andreslucena andreslucena deleted the backport/0.28/migrate-hardcoded-manage-menu--12329 branch January 26, 2024 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Pull Requests that are a backport for a fixed bug module: admin type: fix PRs that implement a fix for a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants