Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport 'Bump stringio and carrierwave' to v0.27 #12449

Conversation

alecslupu
Copy link
Contributor

馃帺 What? Why?

Backport #12132 to v0.27

鈾ワ笍 Thank you!

* Update stringio to v 3.1.0

* Bump carrierwave
@alecslupu alecslupu added backport Pull Requests that are a backport for a fixed bug type: fix PRs that implement a fix for a bug labels Feb 13, 2024
Copy link
Member

@andreslucena andreslucena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It shouldn't happen anything bad, bug just in case: we're also updating other gems here, most notably Rails (from 6.1.6 to 6.1.7.6). Is that intentional? Should we try to only update the ones from the original PR?

@alecslupu
Copy link
Contributor Author

alecslupu commented Feb 14, 2024

It shouldn't happen anything bad, bug just in case: we're also updating other gems here, most notably Rails (from 6.1.6 to 6.1.7.6). Is that intentional? Should we try to only update the ones from the original PR?

Well, we do not have stringio in 0.27, and the Gemfiles generated a conflict. The upgrade and others is because we do not have a stict locking policy added to rails. Meaning, if i have 0.27 project i can. In this particular case i had to run bundle update decidim carriervawe just to generate the proper Gemfile.

In the end, those 2 Gemfiles are not used in the end user deployment. We have *.gemspec for that.
As long the pipeline is green, we should be ok.

@andreslucena
Copy link
Member

As long the pipeline is green, we should be ok.

OK, as is a patch version I'm ok with letting it slide too

@andreslucena andreslucena merged commit d611c85 into release/0.27-stable Feb 15, 2024
46 checks passed
@andreslucena andreslucena deleted the backport/0.27/bump-stringio-and-carrierwave-12132 branch February 15, 2024 06:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Pull Requests that are a backport for a fixed bug type: fix PRs that implement a fix for a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants