Backport 'Allow apps to configure the document types in the verifications module' to v0.27 #12451
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Update i18n translation to id number * Changing DNI strings to Identification number instead * Changing NIE string value to Identification number * Offline review one spec failing * Local tests working omn id_document_offline & online * Generators updated initializer and yml secrets. Update to test to fix CLI * Update to secrets.yml file * Update to README file in verifications * Lint code fix to README file * Change to secrets.yaml file * Reverting secrets file * Verifications model change in the secrets file * Change to config in initalizer.rb * reverting to previous intializer * Test to verifications * Reverting file * Test with a require engine in verifications: Adapter.rb * Reverting initalizer file * Update of the Gemfile in verifications to add a path to verifications * Update of Gemfile using bundle * verifiication change in the gemlog file * Minor change to bundler for gemfile generators on verifations * Reverting file. Verifications path added to generators Gemfile * Verification update on generators and generators_spec files to match branch name * Revert gemfile dependency * Update of release notes for changes in the PR * Update to release notes as per suggestion from andres * Update decidim-generators/lib/decidim/generators/app_templates/initializer.rb Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com> * Update RELEASE_NOTES.md Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com> * Reverting RELEASE_NOTES section to previous version * Reverting initalizer call on verifications * Update of fix lint errors on RELEASE_NOTES * Reverting initalizer change to :decidim, :verifications * Remove to_json as the secret file only translates to array * Change to catch ID no. in initalizer and secret file * Changes to value on indentification number * Changes to form in view * Reverting file due to error * Change to Verifications model to align with intializer and secrets file * Changes to spec for verifications indentification number * Changes to verifications model to test * Reverting config accessor verifications * Changing the generators string to an array * Change to i18n tasks array * Final changes to id_document specs in verifications * Update RELEASE_NOTES.md Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com> * Update RELEASE_NOTES.md Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com> * Update RELEASE_NOTES.md Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com> * Update RELEASE_NOTES.md Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com> * Update RELEASE_NOTES.md Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com> * Update RELEASE_NOTES.md Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com> * Markdownlint changes based on error * Update RELEASE_NOTES.md Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com> * Update RELEASE_NOTES.md Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com> * Update RELEASE_NOTES.md Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com> * Update RELEASE_NOTES.md Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com> * Update decidim-generators/lib/decidim/generators.rb Co-authored-by: Alexandru Emil Lupu <contact@alecslupu.ro> * Update decidim-generators/spec/lib/generators_spec.rb Co-authored-by: Alexandru Emil Lupu <contact@alecslupu.ro> * Update decidim-generators/lib/decidim/generators/app_generator.rb Co-authored-by: Alexandru Emil Lupu <contact@alecslupu.ro> * Update decidim-generators/lib/decidim/generators/app_generator.rb Co-authored-by: Alexandru Emil Lupu <contact@alecslupu.ro> * Update decidim-generators/lib/decidim/generators/app_generator.rb Co-authored-by: Alexandru Emil Lupu <contact@alecslupu.ro> --------- Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com> Co-authored-by: Alexandru Emil Lupu <contact@alecslupu.ro>
alecslupu
added
backport
andreslucena
requested changes
Feb 14, 2024
There was a problem hiding this comment.
Can you add the notes from the RELEASE_NOTES.md to the CHANGELOG.md 🙏🏽?
… backport/0.27/allow-apps-to-configure-the-do-12306
andreslucena
approved these changes
Feb 15, 2024
|
Merging with failing check from codecov |
andreslucena
deleted the
backport/0.27/allow-apps-to-configure-the-do-12306
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
Backport #12306 to v0.27