-
-
Notifications
You must be signed in to change notification settings - Fork 393
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Backport 'Refactor of events specs' to v0.27 #12507
Merged
andreslucena
merged 5 commits into
release/0.27-stable
from
backport/0.27/refactor-of-events-specs-12063
Feb 23, 2024
Merged
Backport 'Refactor of events specs' to v0.27 #12507
andreslucena
merged 5 commits into
release/0.27-stable
from
backport/0.27/refactor-of-events-specs-12063
Feb 23, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Refactor of event_spec in amendment_promoted_event_examples.rb * refactor of event_spec in created_event_examples. Adding of attributes to each modified file * misspelling of arguement test * partial completion of managed_user_error_event_spec * reverting to old version * fix to cli tests * fix to mixed up branch * fixing mix up of commits * refactor of the managed error user error event spec * refactor of create_sortition_event_spec * refactor collaborative_draft_wtihdrawn_spec * refactor of create_meeting_event_spec * refactor of collaborative_draft_access_requested_event_spec * refactor of publish_proposal_event_spec * refactor of voting enabled event spec * refactor of endorsing enbabled event spec * refactor accepted proposal event spec * refactor of evaluatingh proposal event spec * auto-correcting errors * refactor of accepted_proposal_event_spec * refactor for endorising enbabled event * fix for voting_enabled_event_spec.rb * Refactor made to publish proposal event spec * Refactor correction of collaborative draft proposal * refactor correction of create meeting event spec * refactor and corrction of collaborative draft withdrawn * refactor correction of sortitions event spec * refactor of corrections in managed user error event spec * correctable syntax spacing in test * refactor of participory process step changed event spec * Refactor of events for creation_enbabled_event_spec * Deletion of commented out code * Refactor of the collaborative_draft_access_rejected_event_spec * Refactor of collaborative_draft_access_accepted_event_spec * removal of commented out sections * Refactor of participatory_process_step_activated_event_spec * Refactor of participatory_process_role_assigned_event_spec * Refactor of rejected_proposal_event_spec.rb * Refactor of update_proposal_category_event_spec.rb * Refactor for update_proposal_scope_event_spec * Refactor for approve_membership_request_event_spec * Refactor of revoke_membership_request_event_spec * Refactor of support_threshold_reached_event_spec * Refactor of spawn_committee_request_event_spec * Refactor endorse_initiative_event_spec * Refactor of proposal_note_created_event_spec * Removal of :resource object as its used twice in proposal_note_created_event * Refactor of endorse_initiative_event_spec (minor change to test) * Update decidim-initiatives/spec/cells/decidim/initiatives/content_blocks/highlighted_initiatives_cell_spec.rb Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com> --------- Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com>
alecslupu
commented
Feb 22, 2024
alecslupu
commented
Feb 22, 2024
decidim-initiatives/spec/events/decidim/initiatives/endorse_initiative_event_spec.rb
Show resolved
Hide resolved
andreslucena
approved these changes
Feb 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport
Pull Requests that are a backport for a fixed bug
module: core
type: fix
PRs that implement a fix for a bug
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
Backport #12063 to v0.27