Backport 'Implement push notifications for conversations' messages' to v0.27 #12511
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Refactor variables definitions in SendPushNotification spec * Add spec for ConversationMailer It also adds the factories to ease-up the specs * Extract ConversationMailer methods to HasConversation concern * Add PushNotificationMessage model * Implement push notifications for conversations' messages * Fix spec * Simplify PushNotificationMessage model by removing useless attributes * Fix url and icon methods in PushNotificationMessage As a bonus, there are more examples in the spec. * Add missing class in yardoc * Clarify signature * Use more idiomatic way of checking for presence Co-authored-by: Alexandru Emil Lupu <contact@alecslupu.ro> * Move module inclusion to the top for consistency Co-authored-by: Alexandru Emil Lupu <contact@alecslupu.ro> * Add skip_injection on factory definition Co-authored-by: Alexandru Emil Lupu <contact@alecslupu.ro> * Use alias_method for :user * Fix rubocop offenses --------- Co-authored-by: Alexandru Emil Lupu <contact@alecslupu.ro>
alecslupu
added
backport
… backport/0.27/implement-push-notifications-f-12475
andreslucena
requested changes
Feb 27, 2024
decidim-core/app/services/decidim/push_notification_message_sender.rb
Outdated
Show resolved
Hide resolved
Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com>
@andreslucena , i have applied the code suggestion, and for some reason, this does not work as expected with ruby 3.0.x
In order to move forward the PR, I would revert to my initial PR. |
|
Let me check it out in a couple of minutes |
Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com>
andreslucena
approved these changes
Feb 27, 2024
|
Merging with the failing check from codecov |
andreslucena
deleted the
backport/0.27/implement-push-notifications-f-12475
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
Backport #12475 to v0.27