Remove package-lock.json from the webpacker NPM package
#12522
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahukkanen
added
module: core
type: internal
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
alecslupu
requested changes
Feb 23, 2024
That was already done in #9275 I think this file is a leftover from that PR that we didn't delete |
andreslucena
approved these changes
Feb 26, 2024
alecslupu
approved these changes
Feb 26, 2024
I confirm. I reviewed this pr from my phone. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
We only need one
package-lock.jsonand it's the one at the root.The
package-lock.jsonfiles are created at the NPM package folders if you enter those folders and run NPM commands there. But we do not need to ship these with the NPM packages themselves.It was introduced at #9387 and has been updated many times since then.
📌 Related Issues
Testing
See that CI is green.