Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport 'Allow deletion of categories when there are no resources associated' to v0.28 #12527

Conversation

alecslupu
Copy link
Contributor

🎩 What? Why?

Backport #12143 to v0.28

♥️ Thank you!

* Destroy categorization when resource is being destroyed

* Add rake task and RELEASE NOTES

* Fix template

* Prevent destroy command to remove categories in use

* Apply suggestions from code review

Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com>

* Update decidim-core/lib/decidim/core/test/shared_examples/has_category.rb

Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com>

* Running linters

---------

Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com>
@alecslupu alecslupu added backport Pull Requests that are a backport for a fixed bug type: fix PRs that implement a fix for a bug labels Feb 26, 2024
@alecslupu alecslupu marked this pull request as draft February 26, 2024 12:06
github-actions[bot]
github-actions bot previously approved these changes Feb 26, 2024
github-actions[bot]
github-actions bot previously approved these changes Feb 26, 2024
@alecslupu alecslupu marked this pull request as ready for review February 26, 2024 17:22
Copy link
Member

@andreslucena andreslucena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing the RELEASE_NOTES.md entry, can you add it 🙏🏽 ?

@andreslucena andreslucena merged commit b166a38 into release/0.28-stable Feb 27, 2024
103 checks passed
@andreslucena andreslucena deleted the backport/0.28/allow-deletion-of-categories-w-12143 branch February 27, 2024 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Pull Requests that are a backport for a fixed bug type: fix PRs that implement a fix for a bug
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants